Set resolution factor to 1 when a mask is created #3102
Conversation
resolutionfactor=1 when a mask is made
|
Do I get this right: With these changes the mask gets at least always edited with correct dimensions, since the user can't edit the mask with altered frame resolution? And due to that we only suffer from the possible small drift that is caused by mask being parsed and re-written every time any settings are saved? The change looks really hackish with the timeout, though... |
Yes
Have not seen this happening without a resolution change.
I agree, I'm open to better suggestions. |
When the resolution dimmer slider was used (and not set to 100), and a motion or privacy mask was created/changed, the measurement of the width & height went wrong. Because the number of pixels in the image was less.
Example: When the resolution dimmer slider was set to 80 on a camera with a resolution of 1024x768, it measured 819x614.
The 819x614 was converted to the correct resolution when creating the mask file:
DEBUG: building editable motion mask for camera with id 1 (819x614)
DEBUG: editable mask needs resizing from 819x614 to 1024x768
But this caused the mask to change, probably due to the remainder that is or is not present and due to the resizing itself.
This PR makes sure that the resolutionfactor (controlled by the resolution dimmer slider) is always equal to 1 when creating a mask. I had to add a 1 second delay so that this could be processed before the resolution is measured with 'getCameraFrame'. I hope this approach is acceptable.
Issue: #2755